[PATCH] D98488: [CodeCompletion] Avoid spurious signature help for init-list args

Kadir Cetinkaya via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Mar 12 08:59:52 PST 2021


kadircet accepted this revision.
kadircet added a comment.
This revision is now accepted and ready to land.

thanks, lgtm!



================
Comment at: clang/lib/Parse/Parser.cpp:2117
     if (S->getFlags() & Scope::FnScope) {
+      cutOffParsing();
       Actions.CodeCompleteOrdinaryName(getCurScope(),
----------------
i know you are keeping it as is, but what about just calling cutoffparsing before entering the loop once, rather than in 3 places.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98488/new/

https://reviews.llvm.org/D98488



More information about the cfe-commits mailing list