[PATCH] D97183: [analyzer] Add NoteTag for smart-ptr get()

Deep Majumder via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Mar 11 09:37:48 PST 2021


RedDocMD added a comment.

@NoQ, I am using `trackExpressionValue` to add intersetingness to the `InnerPointerVal`. That solves the original problem. However, it is causing the **MoveChecker** to add extra warnings to use-after-move cases. Essentially, when a `unique_ptr` is moved and subsequently used, it triggers two warnings - one from `SmartPointerModelling` and another from `MoveChecker`. It seems to me that two separate checkers are tracking the same bug - use after move. 
So should I make another patch to modify `SmartPointerModelling` to not emit warnings on use after move (instead just leaving the GDM updating code)? Or is there a better solution to this?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97183/new/

https://reviews.llvm.org/D97183



More information about the cfe-commits mailing list