[PATCH] D98424: [clangd] Reject renames to non-identifier characters

Utkarsh Saxena via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Mar 11 09:21:58 PST 2021


usaxena95 accepted this revision.
usaxena95 added a comment.
This revision is now accepted and ready to land.

LGTM. Thanks.



================
Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:466
+    case InvalidName::BadIdentifier:
+      return "the chosen name \"{0}\" is not a valid identifier";
     }
----------------
Please format the string with `Reason.Details`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98424/new/

https://reviews.llvm.org/D98424



More information about the cfe-commits mailing list