[PATCH] D97068: Run non-filechecked commands in update_cc_test_checks.py

Wed Mar 10 15:32:53 PST 2021

ggeorgakoudis added a comment.

In D97068#2617751 <https://reviews.llvm.org/D97068#2617751>, @jroelofs wrote:

> In D97068#2617642 <https://reviews.llvm.org/D97068#2617642>, @ggeorgakoudis wrote:
>
>> Add triple to avoid spurious failures in tests
>
> They're not really spurious, right... Doesn't this mean that `utils/update_cc_test_checks.py` is now broken for people who develop on a mac?

It's spurious in the sense that it's not this commit that breaks mac tests. Testing on mac is already broken. By investigating the issue, you are right that the USER_LABEL_PREFIX `_` is skipping generating the checks because function names mismatch in IR output. I suppose the issue should be fixed by identifying a mac triple and removing the `_` prefix?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97068/new/

https://reviews.llvm.org/D97068