[PATCH] D98135: [OpenMP][InstrProfiling] Fix a missing instr profiling counter

Wed Mar 10 11:21:53 PST 2021

lxfind added a comment.

In D98135#2617448 <https://reviews.llvm.org/D98135#2617448>, @ABataev wrote:

> In D98135#2617446 <https://reviews.llvm.org/D98135#2617446>, @lxfind wrote:
>
>> In D98135#2617432 <https://reviews.llvm.org/D98135#2617432>, @ABataev wrote:
>>
>>> There is a problem. We actually do not emit `S` here directly, instead, we use `CodeGen` lambdas, which may not be equal to `S`, in some cases `S` is `nullptr` here. It may result in not quite accurate results.
>>
>> Thanks for the note! 
>> I don't really know anything about OMP though, not sure how to handle it. 
>> Would you mind taking a look at this issue? Feel free to send a different patch!
>
> Could you create a PR for the problem so we could track it?

https://bugs.llvm.org/show_bug.cgi?id=49521

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98135/new/

https://reviews.llvm.org/D98135