[PATCH] D98135: [OpenMP][InstrProfiling] Fix a missing instr profiling counter

Xun Li via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Mar 10 11:08:30 PST 2021


lxfind added a comment.

In D98135#2617432 <https://reviews.llvm.org/D98135#2617432>, @ABataev wrote:

> There is a problem. We actually do not emit `S` here directly, instead, we use `CodeGen` lambdas, which may not be equal to `S`, in some cases `S` is `nullptr` here. It may result in not quite accurate results.

Thanks for the note! 
I don't really know anything about OMP though, not sure how to handle it. 
Would you mind taking a look at this issue? Feel free to send a different patch!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98135/new/

https://reviews.llvm.org/D98135



More information about the cfe-commits mailing list