[PATCH] D94622: [clang-tidy] add concurrency-async-no-new-threads

Vasily Kulikov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Mar 10 11:00:15 PST 2021


segoon added a comment.

It seems that the related file structure (IOW, "separated coroutine code and non-coroutine code" rule) is indeed specific to Yandex.Taxi. I asked multiple developers in different companies and no one could confirm they align with the rule. The checks in the current form seem to have lower value outside of Yandex.Taxi than I thought. So, I'll close PRs with the checks in the current form (unless someone tell me what part of the check(s) could be used in another way). Thanks for all who reviewed the patches and made suggestions :)

FWIW, we'll still use the checks in Yandex.Taxi. A clang static analyzer check or some other graph analysis / manual attributes marking approach would fit better for the LLVM upstream.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94622/new/

https://reviews.llvm.org/D94622



More information about the cfe-commits mailing list