[PATCH] D98291: [compiler-rt] Fix stale incremental builds when using `LLVM_BUILD_EXTERNAL_COMPILER_RT=ON`.
Dan Liew via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Mar 10 10:09:11 PST 2021
delcypher added a comment.
In D98291#2616865 <https://reviews.llvm.org/D98291#2616865>, @kubamracek wrote:
> Looks good!
>
> By the way, Apple Clang releases also build compiler-rt this way, so it would be worth checking with @arphaman that he's okay with the change.
@kubamracek @arphaman Ah sorry I landed the change before I saw this message. It looks like the `LLVM_BUILD_EXTERNAL_COMPILER_RT` option is used as part of the 2-stage boot strap for AppleClang as it's set in `clang/cmake/caches/Apple-stage2.cmake`. I'll follow up offline.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D98291/new/
https://reviews.llvm.org/D98291
More information about the cfe-commits
mailing list