[PATCH] D96771: [OpenCL] Add distinct file extension for C++ for OpenCL

Andrzej Warzynski via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Mar 10 07:54:24 PST 2021


awarzynski accepted this revision.
awarzynski added a comment.

Thank you for addressing my comments and for working on this! I've left one small suggestion, but that's a [nit].



================
Comment at: clang/test/Driver/cxx_for_opencl.cppcl:1
+// RUN: %clang %s -Xclang -verify -fsyntax-only
+// RUN: %clang %s -cl-std=clc++ -Xclang -verify -fsyntax-only
----------------
This is a very neat test. Would it make sense to add something more basic too? For example (in a separate file):

```
// RUN: %clang %s -fstynax-only -### | FileCheck %s

// CHECK: -x -cppcl
```

This way you would have a bit more explicit test to verifiy that the compiler driver picks the right language based on the extension.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96771/new/

https://reviews.llvm.org/D96771



More information about the cfe-commits mailing list