[PATCH] D97874: [analyzer] Improve SVal cast from integer to bool using known RangeSet

Valeriy Savchenko via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Mar 10 06:07:31 PST 2021


vsavchenko added a comment.

@steakhal I personally don't see any fundamental problems with this patch



================
Comment at: clang/lib/StaticAnalyzer/Core/SValBuilder.cpp:878
+      // Integer is known to be non-zero or zero only.
+      auto truth = State->isNonNull(V);
+      if (truth.isConstrained())
----------------
nit: LLVM coding standards call for variable names starting with upper-case letters. 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97874/new/

https://reviews.llvm.org/D97874



More information about the cfe-commits mailing list