[PATCH] D97857: [Matrix] Add support for matrix-by-scalar division.

Wed Mar 10 03:25:36 PST 2021

fhahn added inline comments.

================
Comment at: clang/test/CodeGen/matrix-type-operators.c:303
 }

+// CHECK-LABEL: @divide_double_matrix_scalar_float(
----------------
everton.constantino wrote:
> Shouldn't a test for half floating point be added here as well? 
Thanks for taking a look! I don't think we have any tests for half floating points at the moment. The tests do not cover each possible combination of types I think, because they re-use the existing code-gen for the stuff that's element type specific (except deciding whether to use floating point or integer ops).

I think it would probably be good to have some FP16 tests though, but that should be a separate change IMO.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97857/new/

https://reviews.llvm.org/D97857