[PATCH] D98070: [clang-tidy] Add option to ignore macros in readability-function-cognitive-complexity check.
Roman Lebedev via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Mar 10 01:14:53 PST 2021
lebedev.ri added a comment.
Please also add a test with global `IgnoreMacros=1` and `readability-function-cognitive-complexity.IgnoreMacros` unset.
(The code is correct as-is, global `IgnoreMacros` should not affect the check here.)
I'm also somewhat worried about forward compatibility.
If in future a mode will be implemented that allows to count the cost of macro arguments,
how'd we expose it in check's params, without breaking the existing `IgnoreMacros=1` config support?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D98070/new/
https://reviews.llvm.org/D98070
More information about the cfe-commits
mailing list