[PATCH] D98291: [compiler-rt] Fix stale incremental builds when using `LLVM_BUILD_EXTERNAL_COMPILER_RT=ON`.

Chris Bieneman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Mar 9 20:47:40 PST 2021


beanz added a comment.

In D98291#2615663 <https://reviews.llvm.org/D98291#2615663>, @delcypher wrote:

> The fact that we have 3 different ways to build compiler-rt in LLVM makes me sad. There should only be 1. I don't have time to do it now but I've filed a radar to do this work at some point (rdar://75248447).

+1,000

The runtimes directory is really the only "correct" way to build the runtime libraries. Someday I hope we can get everything building through it.

In the meantime since reality is a thing... this patch is a good bug fix.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98291/new/

https://reviews.llvm.org/D98291



More information about the cfe-commits mailing list