[PATCH] D98135: [OpenMP][InstrProfiling] Fix a missing instr profiling counter

Fangrui Song via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Mar 9 17:04:55 PST 2021


MaskRay accepted this revision.
MaskRay added a subscriber: vsk.
MaskRay added a comment.
This revision is now accepted and ready to land.

LG, but I hope an OpenMP expert can take a look. Perhaps @vsk can comment on why we hardly have any `@llvm.instrprof.increment` IR test for clang -fprofile-instr-generate.



================
Comment at: clang/test/OpenMP/omp_with_loop_pragma_instr_profile.c:16
+// CHECK-NEXT:  entry:
+// CHECK:         call void @llvm.instrprof.increment
+// CHECK:       omp.precond.then:
----------------
Nit: append a trailing `(` so that it's clear the instruction is `llvm.instrprof.increment`, not `llvm.instrprof.increment.step`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98135/new/

https://reviews.llvm.org/D98135



More information about the cfe-commits mailing list