[PATCH] D98274: [clangd][NFC] Use std::string::replace in SourceCode:applyChange.
Nathan James via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Mar 9 10:58:03 PST 2021
njames93 created this revision.
njames93 added reviewers: sammccall, kadircet.
Herald added subscribers: usaxena95, arphaman.
njames93 requested review of this revision.
Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov.
Herald added a project: clang.
Just looks nicer and easier to read.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D98274
Files:
clang-tools-extra/clangd/SourceCode.cpp
Index: clang-tools-extra/clangd/SourceCode.cpp
===================================================================
--- clang-tools-extra/clangd/SourceCode.cpp
+++ clang-tools-extra/clangd/SourceCode.cpp
@@ -1091,15 +1091,8 @@
"computed range length ({1}).",
*Change.rangeLength, ComputedRangeLength);
- std::string NewContents;
- NewContents.reserve(*StartIndex + Change.text.length() +
- (Contents.length() - *EndIndex));
+ Contents.replace(*StartIndex, *EndIndex - *StartIndex, Change.text);
- NewContents = Contents.substr(0, *StartIndex);
- NewContents += Change.text;
- NewContents += Contents.substr(*EndIndex);
-
- std::swap(Contents, NewContents);
return llvm::Error::success();
}
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D98274.329399.patch
Type: text/x-patch
Size: 763 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20210309/e5443bb3/attachment-0001.bin>
More information about the cfe-commits
mailing list