[PATCH] D98265: [NFC] Use llvm::SmallVector to workaround XL compiler problem on AIX
Xiangling Liao via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Mar 9 08:28:54 PST 2021
Xiangling_L created this revision.
Xiangling_L added reviewers: daltenty, hubert.reinterpretcast, cebowleratibm, jsji, Whitney.
Xiangling_L requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
LLVM is recommending to use SmallVector (that is, omitting the N), in the absence of a well-motivated choice for the number of inlined elements N.
However, this doesn't work well with XL compiler on AIX since some header(s) aren't properly picked up with it. We need to take a further look into the real issue underneath and fix it in a later patch.
But currently we'd like to use this patch to unblock the build compiler issue first.
Note:
The first build failure was spot here: http://lab.llvm.org:8014/#/builders/126/builds/71
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D98265
Files:
clang/lib/CodeGen/CGStmtOpenMP.cpp
Index: clang/lib/CodeGen/CGStmtOpenMP.cpp
===================================================================
--- clang/lib/CodeGen/CGStmtOpenMP.cpp
+++ clang/lib/CodeGen/CGStmtOpenMP.cpp
@@ -1913,7 +1913,7 @@
emitCapturedStmtCall(CodeGenFunction &ParentCGF, EmittedClosureTy Cap,
llvm::ArrayRef<llvm::Value *> Args) {
// Append the closure context to the argument.
- SmallVector<llvm::Value *> EffectiveArgs;
+ llvm::SmallVector<llvm::Value *> EffectiveArgs;
EffectiveArgs.reserve(Args.size() + 1);
llvm::append_range(EffectiveArgs, Args);
EffectiveArgs.push_back(Cap.second);
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D98265.329352.patch
Type: text/x-patch
Size: 615 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20210309/a724b778/attachment.bin>
More information about the cfe-commits
mailing list