[PATCH] D97965: [clang] Fix crash when creating deduction guide.
Adam Czachorowski via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Mar 9 07:41:42 PST 2021
adamcz added inline comments.
================
Comment at: clang/test/SemaCXX/cxx1z-class-template-argument-deduction.cpp:425
+ // This used to crash due to unparsed default arg above.
+ B(); // expected-error {{deduction guide declaration without trailing return type}}
+};
----------------
hokein wrote:
> The diagnostic seems bogus, but I think it is at least better than crashing, I'd add add a FIXME to fix this bogus diagnostic here?.
I added a line about improving the diagnostic. I'm a bit hesitant to leave a FIXME, since it doesn't seem like something actually worth spending time on. Just a weird corner case on broken code.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D97965/new/
https://reviews.llvm.org/D97965
More information about the cfe-commits
mailing list