[PATCH] D98076: [OpenCL][Docs] Release 12.0 notes

[Sven van Haastregt via Phabricator via cfe-commits]

svenvh added inline comments.


================
Comment at: clang/docs/ReleaseNotes.rst:208
+- Added ``-cl-std=CL3.0`` and predefined version macro for OpenCL 3.0.
+- Added ``-cl-std=CL1.0`` and mapped to the existing  OpenCL 1.0 functionality.
+- Improved OpenCL extension handling per target.
----------------



================
Comment at: clang/docs/ReleaseNotes.rst:211
+- Added clang extension for function pointers ``__cl_clang_function_pointers``
+  and  variadic functions ``__cl_clang_variadic_functions``.
+- Improve diagnostics for nested pointers, unevaluated ``vec_step`` expression.
----------------



================
Comment at: clang/docs/ReleaseNotes.rst:214
+- Added ``global_device`` and ``global_host`` address spaces for USM
+  allocations.
+
----------------
Perhaps one more point to mention:
```
 - Allow pointer-to-pointer kernel arguments beyond OpenCL 1.2.
```
(related commit is 523775f96742 ("[OpenCL] Allow pointer-to-pointer kernel args beyond CL 1.2", 2020-12-01)).


================
Comment at: clang/docs/ReleaseNotes.rst:222
+  constructors.
+- Remove warning for variadic macro use.
 
----------------
Nitpick: you're mixing past and present tense ("added" vs "fix").  It would be nicer for consistency to use the same tense everywhere.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98076/new/

https://reviews.llvm.org/D98076