[PATCH] D89986: [AIX] do not emit visibility attribute into IR when there is -mignore-xcoff-visibility

Tue Mar 9 03:26:28 PST 2021

jansvoboda11 added a comment.

In D89986#2612021 <https://reviews.llvm.org/D89986#2612021>, @DiggerLin wrote:

> Gentle ping . @jansvoboda11 .  Do you have any comment on it the last update on  "added -round-trip-args functionality for the lang opt "-mignore-xcoff-visibility" ?

I'd slightly prefer the code for `OPT_mignore_xcoff_visibility` argument generation to be in a similar place the parsing code is (between `OPT_fgnuc_version_EQ ` and `OPT_ftrapv`), but otherwise this change looks good to me.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89986/new/

https://reviews.llvm.org/D89986