[PATCH] D95043: [clangd] Use Dirty Filesystem for cross file rename.

[Kadir Cetinkaya via Phabricator via cfe-commits]

kadircet added inline comments.


================
Comment at: clang-tools-extra/clangd/ClangdServer.cpp:408
+        clangd::rename({Pos, NewName.getValueOr("__clangd_rename_dummy"),
+                        InpAST->AST, File, TFS.view(llvm::None),
+                        /*Index=*/nullptr, RenameOpts});
----------------
sammccall wrote:
> we shouldn't need to pass a nontrivial FS in here, right?
i think this makes sense, as the idea is try to keep it fast by shying away from copying over all the dirty buffers.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95043/new/

https://reviews.llvm.org/D95043