[PATCH] D96975: [Sema] Add some basic lambda capture fix-its

Kirill Bobyrev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Mar 8 05:56:07 PST 2021


kbobyrev added inline comments.


================
Comment at: clang/lib/Sema/SemaExpr.cpp:17453
+    }
+    return T.isPODType(Sema.getASTContext());
+  }();
----------------
sammccall wrote:
> POD is rarely precisely the right concept (and deprecated for that reason).
> Is isTriviallyCopyableType() just as good here?
Also, maybe `if (T->isTriviallyCopyableType(Sema.getASTContext())) return true;` at the top and just `return false;` here? This saves us the necessity to iterate through the ctors.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96975/new/

https://reviews.llvm.org/D96975



More information about the cfe-commits mailing list