[PATCH] D97935: [clangd] Add config support for ResourceDir

Haojian Wu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Mar 8 00:04:28 PST 2021


hokein added a comment.

The code looks good, but I don't have a very strong opinion of making the resource-dir as a config option. Do we have a motivation (e.g. user request?) now?



================
Comment at: clang-tools-extra/clangd/unittests/CompileCommandsTests.cpp:381
 } // namespace clang
-
----------------
looks like  removing the eof is an accident change?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97935/new/

https://reviews.llvm.org/D97935



More information about the cfe-commits mailing list