[PATCH] D98022: [clang] Fix typos in the default logic for CLANG_DEFAULT_UNWINDLIB

Sat Mar 6 22:56:48 PST 2021

MaskRay added a comment.

In D98022#2609597 <https://reviews.llvm.org/D98022#2609597>, @mstorsjo wrote:

> In D98022#2609380 <https://reviews.llvm.org/D98022#2609380>, @MaskRay wrote:
>
>> The test should be fixable with explicit `--unwindlib=platform`.
>
> Sure, but this change also was meant to be a NFC, which it wasn't... so either we make this case set the unwindlib to `""`, or just remove this case (as it never triggered before). As this logic has been in place for quite some time already, it's maybe a bit unnecessary to risk vague changes in behavior due to it.

Deleting the two lines looks fine.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98022/new/

https://reviews.llvm.org/D98022