[PATCH] D98023: [clang] Don't default to a specifically shared libunwind on mingw with a g++ driver

Sat Mar 6 13:42:46 PST 2021

mstorsjo added a comment.

In D98023#2609318 <https://reviews.llvm.org/D98023#2609318>, @phosek wrote:

> We see two test failures that appear to have been introduced by this change:

Hmm - I'm pretty surprised about that, because the change literally added an `&& !TC.getTriple().isOSCygMing()`, which should evaluate to `&& true` when targeting anything else than mingw/cygwin - and the errors you quoted clearly show a linux triple.

I presume you're not actually running the build in a mingw environment, in case that would happen to surprisingly interfere somehow?

Feel free to revert - but I'd appreciate if you could try to figure out why it breaks things, as to me, it should be a clear no-op for linux targets.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98023/new/

https://reviews.llvm.org/D98023