[PATCH] D98128: [clang][clangd] Avoid inconsistent target creation

Tommy Chiang via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat Mar 6 13:26:36 PST 2021


oToToT created this revision.
oToToT added reviewers: sammccall, rsmith, ilya-biryukov.
oToToT added projects: clang, clang-tools-extra.
Herald added subscribers: usaxena95, kadircet, arphaman.
oToToT requested review of this revision.
Herald added subscribers: cfe-commits, sstefan1, MaskRay.
Herald added a reviewer: jdoerfert.

As proposed in D97109 <https://reviews.llvm.org/D97109>, I tried to make target creation consistent in `clang` and `clangd` by replacing the original procedure with a single function introduced in D97493 <https://reviews.llvm.org/D97493>.

This also helps `clangd` works with CUDA, OpenMP, etc.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D98128

Files:
  clang-tools-extra/clangd/Compiler.cpp
  clang/lib/Frontend/ASTUnit.cpp
  clang/lib/Frontend/PrecompiledPreamble.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D98128.328809.patch
Type: text/x-patch
Size: 3976 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20210306/cd790030/attachment.bin>


More information about the cfe-commits mailing list