[PATCH] D89986: [AIX] do not emit visibility attribute into IR when there is -mignore-xcoff-visibility

David Tenty via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Mar 5 15:26:50 PST 2021


daltenty added inline comments.


================
Comment at: clang/lib/Frontend/CompilerInvocation.cpp:3630
+  // no -fvisibility=* option.
+  if (T.isOSAIX() && (Args.hasArg(OPT_mignore_xcoff_visibility) ||
+                      !Args.hasArg(OPT_fvisibility)))
----------------
No sure if we intended to move this block? Regardless, we should probably preserve the extra comments that got added.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89986/new/

https://reviews.llvm.org/D89986



More information about the cfe-commits mailing list