[PATCH] D98023: [clang] Don't make the g++ driver imply an explicitly shared libunwind

Fri Mar 5 08:58:03 PST 2021

mati865 added a comment.

It's clear overlook from D79995 <https://reviews.llvm.org/D79995>, that part is perfectly reasonable to me.

I'm a bit worried about this code though:

  bool AsNeeded = LGT == LibGccType::UnspecifiedLibGcc &&
                  !TC.getTriple().isAndroid() && !TC.getTriple().isOSCygMing();

https://github.com/llvm/llvm-project/blob/0b274ed499603d30694c0b995252ab014609acf9/clang/lib/Driver/ToolChains/CommonArgs.cpp#L1413
IIUC this change would flip it from `false` to `true` for Linux targets, which also sounds fine on it's own but goes beyond this diff description and seems to lack any test.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98023/new/

https://reviews.llvm.org/D98023