[PATCH] D97960: [clang-tidy] bugprone-signal-handler improvements: display call chain

Fri Mar 5 07:18:41 PST 2021

njames93 added a comment.

The issue is FileCheck expects its directives to be in order they appear in the file being checked. Notes are always emitted just after the warning they are attached to.
So there are a few ways to go:

- use CHECK-NOTES-DAG to disregard the ordering and place them next to the location of the note in the code, to give correct line information.
- place the CHECK-NOTES directly after the warning they are attached.

Going with the first option makes it much harder to reason about.
Going with the second option you'll either have to just put a generic number regex for the line number, use (potentially large)  relative `@LINE` offsets or absolute line numbers.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97960/new/

https://reviews.llvm.org/D97960