[PATCH] D97869: [OpenCL][Draft] Add OpenCL builtin test generator

[Anastasia Stulova via Phabricator via cfe-commits]

Anastasia added a comment.

In D97869#2603068 <https://reviews.llvm.org/D97869#2603068>, @svenvh wrote:

> In D97869#2602943 <https://reviews.llvm.org/D97869#2602943>, @Anastasia wrote:
>
>> I was just thinking if we could combine the calls into one function to minimize the number of lines to parse? Perhaps this will make the Tablegen generator too complex?
>
> That will increase the emitter's complexity.  Especially when taking into account the next point about handling optional functionality.  Hard to say in advance if paying for the added emitter complexity is worth the parsing time reduction, though the parsing time reduction is probably not going to be an order of magnitude difference.

We could also consider generating the file with a simple emitter and then partitioning it manually before adding into the repo. But I think you are not suggesting checking it in?

Could you explain a bit more about the overall approach?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97869/new/

https://reviews.llvm.org/D97869