[PATCH] D98022: [clang] Fix typos in the default logic for CLANG_DEFAULT_UNWINDLIB

Martin Storsjö via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Mar 5 01:57:26 PST 2021


mstorsjo created this revision.
mstorsjo added reviewers: saugustine, MaskRay, phosek.
Herald added a subscriber: mgorny.
mstorsjo requested review of this revision.
Herald added a project: clang.

CLANG_DEFAULT_RTLIB had a typo, and libunwind isn't a valid option for it.

This keeps the practical behaviour from before, defaulting to none if using compiler-rt as rtlib.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D98022

Files:
  clang/CMakeLists.txt


Index: clang/CMakeLists.txt
===================================================================
--- clang/CMakeLists.txt
+++ clang/CMakeLists.txt
@@ -262,7 +262,7 @@
 if (CLANG_DEFAULT_UNWINDLIB STREQUAL "")
   if (CLANG_DEFAULT_RTLIB STREQUAL "libgcc")
     set (CLANG_DEFAULT_UNWINDLIB "libgcc" CACHE STRING "" FORCE)
-  elseif (CLANG_DEFAULT_RTLIBS STREQUAL "libunwind")
+  elseif (CLANG_DEFAULT_RTLIB STREQUAL "compiler-rt")
     set (CLANG_DEFAULT_UNWINDLIB "none" CACHE STRING "" FORCE)
   endif()
 endif()


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D98022.328447.patch
Type: text/x-patch
Size: 513 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20210305/fc15bd15/attachment.bin>


More information about the cfe-commits mailing list