[PATCH] D97916: [Driver][RISCV] Support parsing multi-lib config from GCC.

[Zakk Chen via Phabricator via cfe-commits]

khchen added a comment.

Overall LGTM.



================
Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:1604
+  const Arg *A = Args.getLastArg(clang::driver::options::OPT_gcc_toolchain);
+  if (A) {
+    GCCPath = findGCCPath(D, A->getValue());
----------------
khchen wrote:
> if (const Arg *A = Args.getLastArg(clang::driver::options::OPT_gcc_toolchain))
Sorry, I forget this rule: https://llvm.org/docs/CodingStandards.html#don-t-use-else-after-a-return


================
Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:1650
+
+  if (File) {
+    SmallVector<StringRef, 128> Lines;
----------------
kito-cheng wrote:
> khchen wrote:
> > ```
> > if (!File)
> >   return;
> > ```
> Good suggestion, thanks! 
https://llvm.org/docs/CodingStandards.html#don-t-use-braces-on-simple-single-statement-bodies-of-if-else-loop-statements


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97916/new/

https://reviews.llvm.org/D97916