[PATCH] D97950: [clangd] Rename Module -> FeatureModule to avoid confusion. NFC

Sam McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Mar 4 07:24:58 PST 2021


sammccall created this revision.
sammccall added a reviewer: kadircet.
Herald added subscribers: usaxena95, arphaman, mgorny.
sammccall requested review of this revision.
Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov.
Herald added a project: clang.

As pointed out in D96244 <https://reviews.llvm.org/D96244>, "Module" is already pretty overloaded to refer
to clang and llvm modules. (And clangd deals directly with the former).

FeatureModule is a bit of a mouthful but it's pretty self-descriptive.
I think it might be better than "Component" which doesn't really capture
the "common interface" aspect - it's IMO confusing to refer to
"components" but exclude CDB for example.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D97950

Files:
  clang-tools-extra/clangd/CMakeLists.txt
  clang-tools-extra/clangd/ClangdLSPServer.cpp
  clang-tools-extra/clangd/ClangdServer.cpp
  clang-tools-extra/clangd/ClangdServer.h
  clang-tools-extra/clangd/FeatureModule.cpp
  clang-tools-extra/clangd/FeatureModule.h
  clang-tools-extra/clangd/Module.cpp
  clang-tools-extra/clangd/Module.h
  clang-tools-extra/clangd/unittests/ClangdLSPServerTests.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D97950.328167.patch
Type: text/x-patch
Size: 16330 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20210304/5c616a53/attachment.bin>


More information about the cfe-commits mailing list