[PATCH] D97901: [SystemZ] Test for infinity in testFPKind().
Ulrich Weigand via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Mar 4 03:55:45 PST 2021
uweigand added inline comments.
================
Comment at: clang/lib/CodeGen/TargetInfo.cpp:7229
+ case Builtin::BI__builtin_isfinite:
+ Invert = true;
+ LLVM_FALLTHROUGH;
----------------
thopre wrote:
> jonpa wrote:
> > What are these variants all about...?
> >
> They were introduced in https://reviews.llvm.org/D24483
This "invert" logic doesn't look correct. "isfinite" and "isinf" **both** need to return false on NaNs. I think you should just drop the invert logic and use a TDC mask of 0xFC0 (zero, normal, or subnormal) to implement "isfinite".
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D97901/new/
https://reviews.llvm.org/D97901
More information about the cfe-commits
mailing list