[PATCH] D92808: [ObjC][ARC] Use operand bundle 'clang.arc.attachedcall' instead of explicitly emitting retainRV or claimRV calls in the IR

Hans Wennborg via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Mar 4 01:23:56 PST 2021


hans added a comment.

In D92808#2601408 <https://reviews.llvm.org/D92808#2601408>, @fhahn wrote:

> In D92808#2600245 <https://reviews.llvm.org/D92808#2600245>, @hans wrote:
>
>> Reverted in https://github.com/llvm/llvm-project/commit/0a5dd067181dac2a8882a139ea3bd19bdea5fa44 until this can be fixed.
>
> Thanks! I pushed a fix for the issue in 75805dce5ff8 <https://reviews.llvm.org/rG75805dce5ff874676f3559c069fcd6737838f5c0>. @Hans, would it be possible to check if D92808 <https://reviews.llvm.org/D92808> + 75805dce5ff8 <https://reviews.llvm.org/rG75805dce5ff874676f3559c069fcd6737838f5c0> fixes the issue or should we just recommit D92808 <https://reviews.llvm.org/D92808>?

Yes, I confirmed that 75805dce5ff8 <https://reviews.llvm.org/rG75805dce5ff874676f3559c069fcd6737838f5c0> fixes the test case I was looking at. Thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92808/new/

https://reviews.llvm.org/D92808



More information about the cfe-commits mailing list