[PATCH] D96245: [clangd] Propagate CodeActions in addition to Fixes for diagnostics

[Sam McCall via Phabricator via cfe-commits]

sammccall added a comment.

Will the fixes/actions this enables really be available synchronously?

AFAIK the only reasons we attach fixes to diagnostics are:

- because clang fixes are generated at parse time and need to be stored somewhere
- for the benefit of embedders that need the fix content synchronously with the diagnostic
- to trigger the "fix available" text

The first two points don't apply if the fix content is too slow to compute synchronously. (And the third can be more simply solved with a boolean flag instead)

The alternative is just to discover these fixes through the code action flow (and allow modules to contribute code actions, which we should do anyway)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96245/new/

https://reviews.llvm.org/D96245