[PATCH] D97755: [IRSymTab] Set FB_used on llvm.compiler.used symbols

Wed Mar 3 16:08:47 PST 2021

tejohnson accepted this revision.
tejohnson added a comment.
This revision is now accepted and ready to land.

lgtm with change suggested below. Thanks!

================
Comment at: clang/test/CodeGen/thinlto-inline-asm2.c:10
+
+//--- a.c
+const char *ref() {
----------------
MaskRay wrote:
> tejohnson wrote:
> > Is this other file needed for the test?
> This is test the limitation.
> 
> If we fix the tracking for inline asm references (this traverses instructions and I don't know whether it should be fixed):
> 
> without the reference, the `ff_h264_cabac_tables` will be internalized if we don't have a reference. The test ensures that such improvement can be detected.
> 
> `llvm.compiler.used` means the references are seen by the linker, and do not need to suppress internalization if the linker has full knowledge.
Ok, that makes sense. But then please add the same llvm-nm check with comment here as in the other test, so that it fails if that gets changed - I don't think as is this test will fail if that improvement is made.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97755/new/

https://reviews.llvm.org/D97755