[PATCH] D97849: [AST][PCH][ASTImporter] Fix UB caused by uninited SwitchStmt member

Gabor Marton via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Mar 3 10:15:25 PST 2021


martong added a comment.

In D97849#2600300 <https://reviews.llvm.org/D97849#2600300>, @teemperor wrote:

> We can (and do) run LIT tests under valgrind, so if you have a test that triggers this valgrind error then that seems like the way to go. I don't think the test has to deterministically fail outside valgrind to be a valid test.

Do you mean to use lit with `--vg` or should we explicitly call valgrind in a lit test? If the latter, could you please show an example how to do that properly (I could not find any explicit valgrind call, not even in lldb) ?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97849/new/

https://reviews.llvm.org/D97849



More information about the cfe-commits mailing list