[PATCH] D92808: [ObjC][ARC] Use operand bundle 'clang.arc.attachedcall' instead of explicitly emitting retainRV or claimRV calls in the IR

Wed Mar 3 05:55:17 PST 2021

fhahn added a comment.

In D92808#2600031 <https://reviews.llvm.org/D92808#2600031>, @thakis wrote:

>> Thank you. Let me know when you have more information.
>
> Repro is moving along. https://bugs.chromium.org/p/chromium/issues/detail?id=1182642#c26 and onward are getting pretty close.

That's interesting, thanks for sharing! I had a look at the linked good.s/bad.s and the sequence mentioned in the comments looks unexpected. `mov	x29, x29` should be exactly between a regular call and `_objc_retainAutoreleasedReturnValue`, but this is not what's happening in this case. I could not find a link to download the (pre-processed) source file. Would it be possible to get that file?

  Ltmp239:
  	bl	_objc_msgSend
  Ltmp705:
  	mov	x29, x29
  Ltmp240:
  	b	LBB19_3
  LBB19_3:                                ; %invoke.cont4
  	.loc	149 0 9                         ; ../../ios/chrome/browser/ui/infobars/infobar_container_coordinator.mm:0:9
  	bl	_objc_retainAutoreleasedReturnValue

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92808/new/

https://reviews.llvm.org/D92808