[PATCH] D95396: Improve static_assert/_Static_assert diagnostics

Wed Mar 3 05:49:21 PST 2021

aaron.ballman closed this revision.
aaron.ballman added a comment.

In D95396#2598932 <https://reviews.llvm.org/D95396#2598932>, @rsmith wrote:

> Looks like `test/FixIt/fixit-static-assert.cpp` is failing in Phabricator's pre-merge checks: B91556 <https://reviews.llvm.org/B91556>. Please take a look at that before landing this; I think there's a decent chance that it's indicative of a real problem.

The issue was that I was using `Extension` instead of `ExtWarn` for the `'static_assert' with no message` warnings -- I changed it to use `ExtWarn` and fixed up the new tests. If you prefer I use `Extension` instead, I'm happy to do that and change the fixit test instead.

I've commit in 8da090381d567d0ec555840f6b2a651d2997e4b3 <https://reviews.llvm.org/rG8da090381d567d0ec555840f6b2a651d2997e4b3>, thank you for the reviews!

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95396/new/

https://reviews.llvm.org/D95396