[PATCH] D97801: [clangd] Add `limit` extension on completion and workspace-symbols
Kadir Cetinkaya via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Mar 2 22:46:51 PST 2021
kadircet accepted this revision.
kadircet added inline comments.
This revision is now accepted and ready to land.
================
Comment at: clang-tools-extra/clangd/ClangdLSPServer.cpp:784
Server->workspaceSymbols(
- Params.query, Opts.CodeComplete.Limit,
+ Params.query, Params.limit.getValueOr(Opts.CodeComplete.Limit),
[Reply = std::move(Reply),
----------------
should we check for non-negativity in here as well ? (or maybe just change deserialization logic to set it to none for negative ones and store a size_t instead)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D97801/new/
https://reviews.llvm.org/D97801
More information about the cfe-commits
mailing list