[PATCH] D97411: [DebugInfo] Add an attribute to force type info to be emitted for types that are required to be complete.

[Amy Huang via Phabricator via cfe-commits]

akhuang added a comment.

I think they're all singular types, like __hash_node <https://github.com/llvm/llvm-project/blob/5b333d3449fa93cd5b554e1e8b16892031bd8bdf/libcxx/include/__hash_table#L91>. Actually, `__tree_node` might not be problematic.

I could look more at the types if it's helpful; I think the other issue is that there are a lot of libc++ tests and most are not really useful, and I'm kind of building them all and putting all the diffs together. It also seems like the `__hash_node` definitions are all present in the ctor homing dwarfdumps; it's just `__hash_value_type` and `__value_type` that are missing. Not sure why; I would have expected stuff like `__hash_node` to also be missing.

(I saw some other missing types while diffing (like `_Storage` and `__shared_mutex_base`) but looking at the code, it seems like both of those types get constructed, so not sure what's going on there..)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97411/new/

https://reviews.llvm.org/D97411