[PATCH] D97817: [CMake] Rename check-clang-tools to check-clang-tools-extra

Shoaib Meenai via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Mar 2 16:36:59 PST 2021


smeenai added inline comments.


================
Comment at: clang-tools-extra/test/CMakeLists.txt:81
 
-add_lit_testsuite(check-clang-tools "Running the Clang extra tools' regression tests"
+add_lit_testsuite(check-clang-tools-extra "Running the Clang tools extra' regression tests"
   ${CMAKE_CURRENT_BINARY_DIR}
----------------
Nit: You need an explicit "'s" now (as in "Clang tools extra's regression tests"), since "extra" doesn't end with an s.


================
Comment at: clang-tools-extra/test/CMakeLists.txt:87
 
-set_target_properties(check-clang-tools PROPERTIES FOLDER "Clang extra tools' tests")
+set_target_properties(check-clang-tools-extra PROPERTIES FOLDER "Clang tools extra' tests")
 
----------------
Same here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97817/new/

https://reviews.llvm.org/D97817



More information about the cfe-commits mailing list