[PATCH] D97156: [ASTMatchers] Make Param functors variadic

Tue Mar 2 14:20:29 PST 2021

njames93 accepted this revision.
njames93 added a comment.
This revision is now accepted and ready to land.

LGTM, assuming none of the later changes have effected the documentation script.

In D97156#2598398 <https://reviews.llvm.org/D97156#2598398>, @steveire wrote:

> In D97156#2593209 <https://reviews.llvm.org/D97156#2593209>, @njames93 wrote:
>
>> Is it not nicer to name the class `PolymorphicMatcher` and do away with `WithParamN`, It may require partial specialization for the empty parameters case.
>> But I think it would be worth it.
>
> I'm not sure any partial specialization is needed?

Oh neat, I wasn't sure if the empty tuple would cause some issues.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97156/new/

https://reviews.llvm.org/D97156