[PATCH] D97125: Stop traping on sNaN in __builtin_isinf

Thomas Preud'homme via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Mar 2 07:17:19 PST 2021


thopre added a comment.

Ping?



================
Comment at: clang/test/CodeGen/builtin_float_strictfp.c:21
+  // NOFP16-NEXT:  [[IHALF:%.*]]  = load i16, i16* [[LDADDR]], align 2
+  // NOFP16-NEXT:  [[CONV:%.*]]   = call float @llvm.convert.from.fp16.f32(i16 [[IHALF]])
+  // NOFP16-NEXT:  [[IFLOAT:%.*]] = bitcast float [[CONV]] to i32
----------------
thopre wrote:
> Am I right to think that clang should not use llvm.convert here since it's a constrained operation? Any idea why that happens?
Nvm, that's for when fp16 is not supported. I'm guessing this ought to not throw an exception.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97125/new/

https://reviews.llvm.org/D97125



More information about the cfe-commits mailing list