[PATCH] D97752: Fix -gz=zlib options for linker for FreeBSD too

Yaxun Liu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Mar 2 07:17:07 PST 2021


yaxunl added a comment.

In D97752#2596277 <https://reviews.llvm.org/D97752#2596277>, @emaste wrote:

> I can drop the Fixes trailer (I added it as we've adopted it in FreeBSD from Linux). That said, the referenced patch changed Gnu, AMDGPU, and HIP. My main goal here is to get the final library / executable artifacts to have compressed debug, we can look more at the intermediate bits later.
>
> As an aside I'd like to see how we can prevent this kind of divergence; I would expect (what is currently) FreeBSD to be approximately equal to Gnu.

When we see an issue on Linux, it is hard to know whether it also happens to FreeBSD because we do not use FreeBSD on a daily basis. I think a reasonable solution is to add you as reviewer when we encounter similar issues on Linux in the future.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97752/new/

https://reviews.llvm.org/D97752



More information about the cfe-commits mailing list