[PATCH] D97535: [clangd] Use URIs instead of paths in the index file list

Kadir Cetinkaya via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Mar 2 04:42:20 PST 2021


kadircet added a comment.

Right, i see the problem you are trying to solve, and all of this is a mess working nicely in unisom, but falls apart if you try to isolate each piece :/ (hence the need for figuring out list of files while indexing instead)

But until that day, I suppose the best we can do is change the contract of `FileSymbols` to sey keys are always `URIs representing the file producing associated slabs`. This works:

- For preamble symbols, because even though some shards might contain partial information, when merged they indeed correspond to those set of files, and we always query preamble index in a merged fashion.
- Bg-index is literally the same as preamble-index in that regard
- Main file index will only associate slabs with the "main file" now, which will stop the leakage i mentioned above.

Sorry for going in circles here a bit but it took us some time to figure out the issue here, does that make sense for you too?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97535/new/

https://reviews.llvm.org/D97535



More information about the cfe-commits mailing list