[PATCH] D97371: [clang][parser] Remove questionable ProhibitAttributes() call in objc parsing

John McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Mar 1 22:37:13 PST 2021


rjmccall added a comment.

We should never silently accept and ignore an attribute unless (1) that's allowable semantics for the attribute or (2) we have to for source compatibility.  That test is specifically checking that we allow `__attribute__((nomerge))` before `@try` statements.  Are we just dropping the attribute, or are we correctly applying it to calls within the statement?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97371/new/

https://reviews.llvm.org/D97371



More information about the cfe-commits mailing list