[PATCH] D97632: [clang-tidy] Simplify diagnostics for UniqueptrResetRelease check

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Mar 1 10:19:04 PST 2021


aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.

LGTM aside from a nit with the diagnostic wording.



================
Comment at: clang-tools-extra/clang-tidy/misc/UniqueptrResetReleaseCheck.cpp:115
+  auto D = diag(ResetMember->getExprLoc(),
+                "prefer 'unique_ptr<>' assignment over release and reset");
+  if (ResetMember->isArrow())
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97632/new/

https://reviews.llvm.org/D97632



More information about the cfe-commits mailing list