[PATCH] D97573: [OpenMP] Handle non-function context before checking for diagnostic emission

PremAnand Rao via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Mar 1 07:57:27 PST 2021


pmrao added inline comments.


================
Comment at: clang/lib/Sema/SemaOpenMP.cpp:1946
+    FunctionEmissionStatus FES = getEmissionStatus(FD);
+    switch (FES) {
+    case FunctionEmissionStatus::Emitted:
----------------
erichkeane wrote:
> Tabs here instead of spaces.
> 
> I think this is the right fix for SYCL, but @bader  should double-check that he's ok with this or OMP.
> Tabs here instead of spaces.

Are you suggesting that I change the spaces to tabs instead?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97573/new/

https://reviews.llvm.org/D97573



More information about the cfe-commits mailing list