[PATCH] D96612: [clangd] Improve printing of Objective-C categories and methods

Sam McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat Feb 27 13:35:48 PST 2021


sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.

Great, thanks!



================
Comment at: clang-tools-extra/clangd/FindSymbols.cpp:176
+std::string getSymbolName(ASTContext &Ctx, const NamedDecl &ND) {
+  if (const auto *Container = dyn_cast<ObjCContainerDecl>(&ND))
+    return printObjCContainer(*Container);
----------------
can we motivate this with a comment?
// print X rather than Y


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96612/new/

https://reviews.llvm.org/D96612



More information about the cfe-commits mailing list